Skip to content

Comments

[CI] Run swiftformat in style.sh on Linux#14807

Closed
andrewheard wants to merge 3 commits intomainfrom
ah/style-linux
Closed

[CI] Run swiftformat in style.sh on Linux#14807
andrewheard wants to merge 3 commits intomainfrom
ah/style-linux

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented May 2, 2025 •
edited
Loading

Fixed the style.sh script to run on Linux. The check workflow now runs on Ubuntu and was ignoring Swift style issues since the script checked "$system" == 'Darwin'.

#no-changelog

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented May 2, 2025

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@andrewheard andrewheard marked this pull request as ready for review May 2, 2025 21:19
@andrewheard andrewheard requested a review from paulb777 May 2, 2025 21:19
@andrewheard
Copy link
Contributor Author

andrewheard commented May 2, 2025

Addressed in #14808.

@andrewheard andrewheard closed this May 2, 2025
@firebase firebase locked and limited conversation to collaborators Jul 18, 2025
@paulb777 paulb777 deleted the ah/style-linux branch February 18, 2026 00:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 Awaiting requested review from paulb777

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andrewheard